commit 8cfc835755fc31c5233d59e92ea6e9f763c44dce Author: Opensource Date: Mon Apr 15 20:09:33 2019 -0400 Remove unneeded Lists.scala implicits imports (#13478) `git grep --files-with-matches "import io.fsq.common.scala.Lists" | xargs grep -L "swap\|partitionInPlace\|removeAll\|removeAllBy\|aggregate\|product\|productReverse\|powerset\|powerset\|nth\|sequence1\|sequence2\|map12\|map1\|map1\|unfold\|shuffled\|shuffledDeterministically\|sample\|toListBy\|flatToListBy\|toVectorBy\|flatToVectorBy\|toArrayBy\|flatToArrayBy\|toSetBy\|toMapBy\|toMutableMapBy\|flatToSetBy\|flatToMapBy\|toMapByKey\|flatToMapByKey\|topNSorted\|mkJoin\|has\|flatGroupBy\|mapAccum\|flatMapAccum\|distinctBy\|flatDistinctBy\|countDistinctBy\|distinctCounts\|minByOption\|minOption\|maxOption\|maxByOption\|collectFirstOpt\|tailOption\|groupWhile\|crowd\|histogramBy\|partitionN\|chunkMap\|slidingPairs\|chunkFlatMap\|filterOutWith\|groupByKeyValueSet\|toMapAccumValueSet\|groupByKeyValue\|toMapAccumValues\|topNUnsorted\|topNSorted\|topNPartition\|flatMapFind\|exactlyOne\|hasOverlap\|zipOption\|zipLeftOption\|zipRightOption\|yankToIndex\|indexWhereOption\|indexOfOption\|nth\|pth\|sortByDesc\|sortedDesc\|insertAfter\|hasKey\|invert\|flattenValues\|mappedValues\|flatMapValues\|isEmptyOr\|unzipped\|flatCollect\|toVectorBy\|flatToVectorBy\|Rand\|sumBy\|slidingOptPairs" | xargs sed -i '' '/import.*Lists.Implicits/d'` (sapling split of 06c0771b48844a64a1ae1c6dc771be109ea032b4) .../io/fsq/exceptionator/actions/concrete/ConcreteNoticeActions.scala | 1 - 1 file changed, 1 deletion(-) commit e0634b990d528161c27db5bb8624f61ca411fda3 Author: Jacob Van De Weert Date: Fri Mar 1 16:28:55 2019 +0000 fix exceptionator deleting notices on bucket removal (#11974) We should only be deleting the notice when the last bucket is removed from it. (sapling split of dffac77c2831ee289bb6df5dabefc5fe93657ee6) .../exceptionator/actions/concrete/ConcreteNoticeActions.scala | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit 8076dc58409e30994f71643e3fd3a8d6b4dbbc48 Author: Jacob Van De Weert Date: Fri Mar 1 16:28:30 2019 +0000 fix DateTime creation in exceptionator historyActions.oldestId (#11916) This would be a type error, except that DateTime apparently has a constructor which takes an Object. RIP type safety. (sapling split of f550190d9d702cc5e805582578f19636586accba) .../io/fsq/exceptionator/actions/concrete/ConcreteHistoryActions.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f2143272580778c13d834d59ec83a2dca25ca0cb Author: Jacob Van De Weert Date: Wed Feb 27 18:37:00 2019 +0000 exceptionator: fix running with custom mongo server location (#11870) We lost exceptionator's mongo boot code in the thrift switchover, which I missed in the review (it was a large change!) but discovered when trying to deploy a bug fix last week. This restores it and updates it for the new world, including adding back some indexes that were missing on the thrift models. (sapling split of 4a42fbb5e39c33c5c3e5967ec04e9785660cc122) .../actions/concrete/ConcreteBucketActions.scala | 23 +++------------------ .../actions/concrete/ConcreteHistoryActions.scala | 24 ++++------------------ .../actions/concrete/ConcreteNoticeActions.scala | 24 ++++------------------ 3 files changed, 11 insertions(+), 60 deletions(-) commit 455910c18892accd5bcf48cc4038f67cc6daabbd Author: Jamie Alexander Date: Mon Sep 17 16:25:52 2018 -0400 Port exceptionator to thrift (#8284) (sapling split of 622faaa047ef2b2c2bdfe97b541d374557195caa) .../concrete/ConcreteBackgroundActions.scala | 2 +- .../actions/concrete/ConcreteBucketActions.scala | 224 ++++++++++++------ .../actions/concrete/ConcreteHistoryActions.scala | 263 +++++++++++++-------- .../actions/concrete/ConcreteIncomingActions.scala | 7 +- .../actions/concrete/ConcreteNoticeActions.scala | 128 +++++++--- .../EmailFreshExceptionBackgroundAction.scala | 18 +- 6 files changed, 414 insertions(+), 228 deletions(-) commit 964af761e0a4e12fd1f2935fe89e1d740e672be2 Author: Ian Tabolt Date: Thu Jun 7 17:37:40 2018 -0400 Scalafmt exceptionator (#6761) This is to test the waters on some code that devsys owns before rolling out to the rest of the codebase * Run Scalafmt on exceptionator * Add braces around multiline methods * Fixlint to pass CI * Don't align case => and fix weird formats (sapling split of 551575423740c8e84d6ec8d7b02b8c43420dda10) .../concrete/ConcreteBackgroundActions.scala | 11 +- .../actions/concrete/ConcreteBucketActions.scala | 156 ++++++++++++--------- .../actions/concrete/ConcreteHistoryActions.scala | 71 +++++----- .../actions/concrete/ConcreteIncomingActions.scala | 25 ++-- .../actions/concrete/ConcreteNoticeActions.scala | 16 ++- .../EmailFreshExceptionBackgroundAction.scala | 68 ++++----- 6 files changed, 188 insertions(+), 159 deletions(-) commit e7641f3d49bc22c21d8856c135e058f4dac7c80f Author: Jacob Van De Weert Date: Thu Jan 25 02:18:57 2018 +0000 correctly purge ttl'ed exceptionator history (#4362) The existing implementation was bugged in that it would only delete stale notices that still existed in buckets -- in effect only notices that occurred very infrequently. This change adds some logic to store the earliest notice expiration time on the history record and perform deletions based upon that value, to include notices that might have been cycled out of their buckets' ring buffers but still exist in the sampled history. (sapling split of a16be37c7c63df5b4af8de0e28a080c357d1ac6e) .../actions/concrete/ConcreteHistoryActions.scala | 23 +++++++++++----------- .../actions/concrete/ConcreteIncomingActions.scala | 2 +- 2 files changed, 13 insertions(+), 12 deletions(-) commit efa8e95ba57c9f72eca2af0778c30be0c625dd3a Author: Jacob Van De Weert Date: Wed Jan 24 00:49:36 2018 +0000 add ttl support to exceptionator (#4317) * add ttl support to exceptionator This change allows expiring notice data earlier than it would otherwise be removed by being cycled out of buckets or history. Unfortunately, we cannot simply make use of mongo's ttl indexes due to the data storage model used by exceptionator, but we can just tag some work onto the existing maintenance for deleting old histograms and buckets. (sapling split of 7831e448cb07346db2171ee2acd7db89a9e128b1) .../actions/concrete/ConcreteBucketActions.scala | 21 ++++++++------ .../actions/concrete/ConcreteHistoryActions.scala | 28 +++++++++++++++++++ .../actions/concrete/ConcreteIncomingActions.scala | 32 ++++++++++++++-------- .../actions/concrete/ConcreteNoticeActions.scala | 8 ++++++ 4 files changed, 69 insertions(+), 20 deletions(-)